Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to update ontology. #527

Merged
merged 7 commits into from
Jan 20, 2023

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Jan 19, 2023

Description:

If a file with name as the output ontology already exists it will automatically load this ontology and only add new concepts that are not already defined.

Updating the ontology instead of regenerating is the default, but can be overridden with -update_ontology= False. A completely new ontology will then be regenerated.

for excel2onto: If input_ontologyis not given it will take this as equal to outputname, but can also be specified to be different.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb linked an issue Jan 19, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #527 (aba2b36) into master (c3f5403) will increase coverage by 0.03%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   65.52%   65.55%   +0.03%     
==========================================
  Files          16       16              
  Lines        3086     3089       +3     
==========================================
+ Hits         2022     2025       +3     
  Misses       1064     1064              
Impacted Files Coverage Δ
ontopy/excelparser.py 80.08% <85.71%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@lovfall lovfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@francescalb francescalb merged commit d827d7a into master Jan 20, 2023
@francescalb francescalb deleted the 501-excel2onto-support-updating-ontology branch January 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excel2onto: support updating ontology
3 participants